https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94248
Thomas Schwinge <tschwinge at gcc dot gnu.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Last reconfirmed|2020-03-21 00:00:00 |2020-4-21
Keywords| |patch
--- Comment #4 from Thomas Schwinge <tschwinge at gcc dot gnu.org> ---
(In reply to Andrew Stubbs from comment #3)
> Actually, I think that recent changes to the register alignment mean that
> this can't happen any more, so the whole check is probably obsolete.
I don't know exactly what "this" and "the whole check" relate to, but I do
reconfirm that without Jakub's 'reg_overlap_mentioned_p' patch, I'm still
running into the ICE.
> I thought that --enable-checking=yes was already covering this. :-(
Nope. :-|
Thus, again:
(In reply to Thomas Schwinge from comment #2)
> (In reply to Jakub Jelinek from comment #1)
> > --- gcc/config/gcn/gcn.md.jj 2020-03-03 07:57:42.363827602 +0100
> > +++ gcc/config/gcn/gcn.md 2020-03-21 15:37:45.337552515 +0100
> > @@ -625,7 +625,7 @@ (define_insn_and_split "*mov<mode>_insn"
> > rtx outhi = gen_highpart_mode (SImode, <MODE>mode, operands[0]);
> >
> > /* Ensure that overlapping registers aren't corrupted. */
> > - if (REGNO (outlo) == REGNO (inhi))
> > + if (reg_overlap_mentioned_p (outlo, inhi))
> > {
> > operands[0] = outhi;
> > operands[1] = inhi;
> > ought to fix this
>
> I've tested that one; no more ICE, and bit-identical code for all target
> libraries, so I suppose this is good to commit (Andrew, Julian)? If
> approving this patch, please respond with "Reviewed-by: NAME <EMAIL>" so
> that your effort will be recorded in the commit log, see
> <https://gcc.gnu.org/wiki/Reviewed-by>.
