[Bug other/94629] 10 issues located by the PVS-studio static analyzer

[redi at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94629

--- Comment #17 from Jonathan Wakely <redi at gcc dot gnu.org> ---
(In reply to David Binderman from comment #14)
> There is also this one from cppcheck:
> 
> trunk.git/libstdc++-v3/include/debug/formatter.h:302:40: warning: Redundant
> assignment of '_M_variant._M_iterator._M_constness' to itself.
> [selfAssignment]
> 
> Source code is
> 
>       _M_variant._M_iterator._M_constness =
>       _M_variant._M_iterator._M_constness =
>         __it._S_constant() ? __const_iterator : __mutable_iterator;

That's now fixed, thanks.