https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92848
--- Comment #4 from jules at gcc dot gnu.org --- (In reply to Thomas Schwinge from comment #3) > (In reply to jules from comment #2) > > Again, please don't change this code under the feet of the refcount overhaul > > patch! > > But why? This here is one independent chance. The big "OpenACC reference > count overhaul" will then either lose some of its changes, or replace this > here by something else ('GOMP_MAP_VARS_OPENACC_ENTER_DATA'), but it's an > incremental step (forward). It's hard for me to evaluate if the changes are correct, given that I don't trust the current baseline, mostly. > > Using the (currently OpenMP-specific) GOMP_MAP_VARS_ENTER_DATA is > > going to end up mighty confusing from OpenACC-specific code. > > Why do you think so? It has exactly! the semantics that we need here, for > this PR. Is the desired behaviour change just the reference count initialized by target.c:gomp_map_vars_internal? I suppose that's OK. The danger is if the semantics needed for OpenMP ever shift away from what we need for OpenACC here. But I guess this code might not be around for long anyway?