[Bug c++/87996] [8/9 Regression] "size of array is negative" error when SIZE_MAX/2 < sizeof(array) <= SIZE_MAX

[msebor at gcc dot gnu.org]

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=87996

--- Comment #5 from Martin Sebor <msebor at gcc dot gnu.org> ---
Author: msebor
Date: Mon Feb 11 17:35:17 2019
New Revision: 268774

URL: https://gcc.gnu.org/viewcvs?rev=268774&root=gcc&view=rev
Log:
PR c++/87996 - size of array is negative error when SIZE_MAX/2 < sizeof(array)
<= SIZE_MAX

gcc/ChangeLog:

        PR c++/87996
        * builtins.c (max_object_size): Move from here...
        * builtins.h (max_object_size): ...and here...
        * tree.c (max_object_size): ...to here...
        * tree.h (max_object_size): ...and here.

gcc/c-family/ChangeLog:

        PR c++/87996
        * c-common.c (invalid_array_size_error): New function.
        (valid_array_size_p): Call it.  Handle size as well as type.
        * c-common.h (valid_constant_size_p): New function.
        (enum cst_size_error): New type.

gcc/cp/ChangeLog:

        PR c++/87996
        * decl.c (compute_array_index_type_loc): Preserve signed sizes
        for diagnostics.  Call valid_array_size_p instead of error.
        * init.c (build_new_1): Compute size for diagnostic.  Call
        invalid_array_size_error
        (build_new): Call valid_array_size_p instead of error.

gcc/testsuite/ChangeLog:

        PR c++/87996
        * c-c++-common/array-5.c: New test.
        * c-c++-common/pr68107.c: Adjust text of diagnostics.
        * g++.dg/init/new38.C: Same.
        * g++.dg/init/new43.C: Same.
        * g++.dg/init/new44.C: Same.
        * g++.dg/init/new46.C: Same.
        * g++.dg/other/large-size-array.C: Same.
        * g++.dg/other/new-size-type.C: Same.
        * g++.dg/template/array30.C: Same.
        * g++.dg/template/array32.C: New test.
        * g++.dg/template/dependent-name3.C: Adjust.
        * gcc.dg/large-size-array-3.c: Same.
        * gcc.dg/large-size-array-5.c: Same.
        * gcc.dg/large-size-array.c: Same.
        * g++.old-deja/g++.brendan/array1.C: Same.
        * g++.old-deja/g++.mike/p6149.C: Same.


Added:
    trunk/gcc/testsuite/c-c++-common/array-5.c
    trunk/gcc/testsuite/g++.dg/template/array32.C
Modified:
    trunk/gcc/ChangeLog
    trunk/gcc/builtins.c
    trunk/gcc/builtins.h
    trunk/gcc/c-family/ChangeLog
    trunk/gcc/c-family/c-common.c
    trunk/gcc/c-family/c-common.h
    trunk/gcc/cp/ChangeLog
    trunk/gcc/cp/decl.c
    trunk/gcc/cp/init.c
    trunk/gcc/testsuite/ChangeLog
    trunk/gcc/testsuite/c-c++-common/pr68107.c
    trunk/gcc/testsuite/g++.dg/init/new38.C
    trunk/gcc/testsuite/g++.dg/init/new43.C
    trunk/gcc/testsuite/g++.dg/init/new44.C
    trunk/gcc/testsuite/g++.dg/init/new46.C
    trunk/gcc/testsuite/g++.dg/other/large-size-array.C
    trunk/gcc/testsuite/g++.dg/other/new-size-type.C
    trunk/gcc/testsuite/g++.dg/template/array30.C
    trunk/gcc/testsuite/g++.dg/template/dependent-name3.C
    trunk/gcc/testsuite/g++.dg/ubsan/pr81530.C
    trunk/gcc/testsuite/g++.old-deja/g++.brendan/array1.C
    trunk/gcc/testsuite/g++.old-deja/g++.mike/p6149.C
    trunk/gcc/testsuite/gcc.dg/large-size-array-3.c
    trunk/gcc/testsuite/gcc.dg/large-size-array-5.c
    trunk/gcc/testsuite/gcc.dg/large-size-array.c
    trunk/gcc/tree.c
    trunk/gcc/tree.h