http://gcc.gnu.org/bugzilla/show_bug.cgi?id=53001

--- Comment #21 from Manuel López-Ibáñez <manu at gcc dot gnu.org> ---
(In reply to Joshua Cogliati from comment #20)
> Created attachment 30937 [details]
> Patch to add -Wfloat-conversion option against trunk
> 
> Added one more changed needed to get it to compile (which only occured if I
> did an rm -Rf in the build directry, the make bootstrap didn't catch the
> libcpp warning found.)  
> 
> The only thing I have left is to possibly modify the test scripts (to use
> -Wfloat-conversion instead of -Wconversion for the relevant tests) and
> recompile against the current trunk.

I would humbly suggest that you first recompile against current trunk, then
submit to gcc-patches and CC Dodji and Jason Merrill (you can find the emails
in MAINTAINERS) asking for comments before spending time and effort on updating
the test cases. The maintainers may ask you to change the name, or they might
not like that it triggers so often in GCC (so they may ask you to not enable it
with -Wextra), or they might simply not like the patch at all. 

Please mention that it is your first patch to GCC and your copyright assignment
is already in order. People are reluctant to review patches unless the papers
are in order since there is a high chance that they will never be committed.

Reply via email to