http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55551



--- Comment #9 from Teresa Johnson <tejohnson at google dot com> 2012-12-01 
16:38:25 UTC ---

On Sat, Dec 1, 2012 at 1:01 AM, markus at trippelsdorf dot de

<gcc-bugzi...@gcc.gnu.org> wrote:

>

> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55551

>

> --- Comment #8 from Markus Trippelsdorf <markus at trippelsdorf dot de> 
> 2012-12-01 09:01:33 UTC ---

> (In reply to comment #5)

>>

>> Index: lto-cgraph.c

>> ===================================================================

>> --- lto-cgraph.c        (revision 193999)

>> +++ lto-cgraph.c        (working copy)

>> @@ -1345,7 +1345,8 @@ merge_profile_summaries (struct lto_file_decl_data

>>          /* Save a pointer to the profile_info with the largest

>>             scaled sum_all and the scale for use in merging the

>>             histogram.  */

>> -        if (lto_gcov_summary.sum_all > saved_sum_all)

>> +        if (!saved_profile_info

>> +            || lto_gcov_summary.sum_all > saved_sum_all)

>>            {

>>              saved_profile_info = &file_data->profile_info;

>>              saved_sum_all = lto_gcov_summary.sum_all;

>>

>> Can you try adding this patch and seeing if that fixes the issue? I

>> will hold off on sending the first fix for review  to see if I should

>> add this one.

>

> Yes this fixes the issue. Firefox now builds fine.

> Thanks.



This is exactly what is happening. From gcov-dump on test.gcda:



test.gcda: a3000000:  22:PROGRAM_SUMMARY checksum=0x01847361

test.gcda:              counts=617, runs=5, sum_all=0, run_max=0, sum_max=0

test.gcda:              counter histogram:

test.gcda:              0: num counts=617, min counter=0, cum_counter=0



Not sure why there are no non-zero counters when there are >0 runs,

but the above patch handles this situation.



Will send in patch a little later today when bootstrap tests complete.

Teresa





>

> --

> Configure bugmail: http://gcc.gnu.org/bugzilla/userprefs.cgi?tab=email

> ------- You are receiving this mail because: -------

> You are on the CC list for the bug.







--

Teresa Johnson | Software Engineer | tejohn...@google.com | 408-460-2413

Reply via email to