http://gcc.gnu.org/bugzilla/show_bug.cgi?id=54455

--- Comment #10 from Andrey Belevantsev <abel at gcc dot gnu.org> 2012-09-03 
08:21:20 UTC ---
(In reply to comment #9)
> Created attachment 28121 [details]
> gcc48-pr54455.patch
> 
> Patch for 2).  asm goto with fallthru labels is pretty hard case, handled in
> cfgrtl.c hopefully right, but sel-sched apparently wants to do everything on
> its own.  Best is to punt in that case and leave it to cfgrtl.

The patch looks perfectly fine, some thoughts:
1) a test case with sel-sched specific flags should be added,
2) the new code looks like a good helper for cfgrtl.c, would it be good to add
it there?
3) re. cfgrtl handling of asm goto, what do you think of PR 51106?  Last time
we discussed this we ended up with
http://gcc.gnu.org/ml/gcc-patches/2012-04/msg00161.html

I can pick up your patch and do 1) and 2) with testing etc.

Reply via email to