http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49194

--- Comment #3 from Jan Hubicka <hubicka at ucw dot cz> 2011-05-27 16:15:02 UTC 
---
> I agree if the called function is big and it is very unlikely (most probably
> just in PROB_VERY_UNLIKELY cases) -finline-functions-called-once shouldn't
> inline.

-finline-functions-called-once  is trottled down by the large-function-growth
and large-stack-frame-growth limits. The  Kernel case coupld proably be handled
by the second. Does kernel bump down that limits?
It still won't help in case function doesn't have any on-stack aggregates,
since we optimistically assume that all gimple registers will disappear.
Probably
even that could be change, though estimating reload's stack frame usage so
early would
be iffy.

I agree that both limits are bit high for this particular case. However I
experimented with bumping this down some time ago with an extra parameter and
did not find any practictical benefit that would justify adding yet another
limit to the inliner.

So testcases would be welcome.
Honza

Reply via email to