------- Comment #6 from spop at gcc dot gnu dot org 2008-12-20 07:43 ------- Subject: Re: Matrix.c from pymol 1.1r2 fails to compile with -O2 -fgraphite
> ------- Comment #4 from hjagasia at gcc dot gnu dot org 2008-12-19 18:20 > ------- > Created an attachment (id=16946) --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=16946&action=view) > --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=16946&action=view) > Fixed changes suggested by Sebastian Pop. > Why did you introduced all these calls of recompute_all_dominators before the graphite_verify functions? Are all these calls needed? I don't think so. For instance, here: + recompute_all_dominators (); graphite_verify (); cleanup_tree_cfg (); recompute_all_dominators (); recompute_all_dominators is called twice with just cleanup_tree_cfg in between. I do not like the recompute_all_dominators calls: in the long run we should have all this information correctly updated during code generation, and not rely at all on recompute_all_dominators. If you can minimize the number of calls to recompute_all_dominators it would be nice, otherwise the patch is ok. Thanks, Sebastian -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=38510
