------- Comment #6 from mark at codesourcery dot com 2008-01-20 20:28 ------- Subject: Re: [4.2/4.3 Regression] bit-fields, references and overloads
aoliva at gcc dot gnu dot org wrote: > ------- Comment #5 from aoliva at gcc dot gnu dot org 2008-01-17 18:01 > ------- > Created an attachment (id=14959) --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=14959&action=view) > --> (http://gcc.gnu.org/bugzilla/attachment.cgi?id=14959&action=view) > Slight revision of Jakub's patch that fixes the regression > > Getting built-in candidate functions not to use the bit-field types fixed the > regression Jakub noticed in his patch, and keeps the progression in place. > I'm > almost done testing this, and I'll post it to gcc-patches then. Thank you for working on this. I think this is the right idea, but I have two comments: * In add_builtin_candidates, I think you can just do: argtypes[i] = unlowered_expr_type (lvalue_type (args[i])); * In layout_class_type, I understand that you're trying to preserve cv-qualification. I don't see a test case for that, though. If there's a bug you're fixing here, let's have a test case for it. Thanks, -- http://gcc.gnu.org/bugzilla/show_bug.cgi?id=33984