------- Comment #11 from magnus at greatlord dot com  2007-06-03 17:48 -------
Hi

I look at both patcher the frist one the
"GCC-v4.1-r120189-CreateFileMapping-Vista.patch" is most correct one in my
eyes. 

if you reading how CreateFileMapping works, at
http://msdn2.microsoft.com/en-us/library/aa366537.aspx

I interper it the text as u always need to use "local\\name" to support more
that one user. 

we need rember that apps can get admin right  in NT 2003 and down when they
runs so they where allown to use NULL in the last param and gain admins right
in vista this is not posible any longer, letting program getting admin right 
when user have limit right. so now all program need follow the api to proper

Now we looking at the second patch the host-mingw32.c.diff 
I have not tested it in vista or windows yet. But what I can see
it using vritualalloc that mean it alloc memory and getting allot slower
against
FileMapping we talking about allot extra comping time, and it is not a good
idea for big project like reactos, and another thing the swap file will incress
and windows does not always cleanup stuff in the swapfile until a reboot, that
is few big disages with host-mingw32.c.diff it exists allot other disgante over
it also.


-- 


http://gcc.gnu.org/bugzilla/show_bug.cgi?id=30335

Reply via email to