On Tue, Jan 16, 2024 at 07:32:56PM +0800, Qian Yun wrote:
> This is the second patch (of two) to enable correct collection
> of statistics information on recursive calls to interpreter.
>
> Move $statsInfo and other global variables required for timing
> to the top of $timedNameStack.
>
> Since $timedNameStack now has dynamic scope, recursive timing
> is correctly supported after this patch.
This business with 'topFrame' looks fishy. Stack should be
a stack, but you effectively turn top item into a global
variable and push below it. I did not analyzed the whole
of the patch, but ATM moment my feeling is "there should be
better way".
--
Waldek Hebisch
--
You received this message because you are subscribed to the Google Groups
"FriCAS - computer algebra system" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/fricas-devel/ZaclbJ4n-CA-yf3p%40fricas.org.
