On Wed, Nov 15, 2023 at 06:00:26PM +0800, Qian Yun wrote:
> This is a relatively large misc cleanup, so I'd like a review before
> commit.
Looks mostly good. But I have doubts about two changes to
fricas-lisp.lisp. First, removing extern declaration of 'sock_get_float'
looks dangerous. Namely, extern declarations are needed.
We provide extern declarations for ECL in 'ecl-foreign-call',
but we do not do this for GCL. Is GCL providing extern
declarations? If not we need our own. Second, I do not
know why you want to move definition of 'sockSendString'?
It is closely related to 'sock_send_string_len' and keeping
them together looks clearer for me.
> A question: shall we remove GCL_DIST related stuff in
> src/scripts/mkdist.sh?
Probably. It was not used for many years and there is low probability
that it will be needed in the future.
--
Waldek Hebisch
--
You received this message because you are subscribed to the Google Groups
"FriCAS - computer algebra system" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/fricas-devel/ZVgpf2hgqVsTjmF3%40fricas.org.
