On Tue, Nov 07, 2023 at 07:49:06PM +0800, Qian Yun wrote:
> Finally I can get FriCAS compiled on Android with SBCL.
> The running speed is not bad.
> 
> The most important step is to get SBCL binary for Android from:
> https://github.com/bohonghuang/sbcl-termux-build
> 
> Only one build error: "error: unknown type name 'fd_set'".
> 
> 'fd_set' is defined in "sys/select.h", so it seems that it is implicitly
> included by "sys/types.h" (via __USE_MISC macro).

Old standard says that select should be defined in "unistd.h" and
releated types in "sys/types.h" and "sys/time.h".  It probably
makes sense to switch to new standard and use "sys/select.h"
(as you propose).

Related thing is that select and related types seem to be used
only in 'sockio.c', so it would make sense to move all related
declarations to 'sockio.c'.

> Following patch fixes it.
> 
> - Qian
> 
> diff --git a/src/include/com.h b/src/include/com.h
> index 470018b9..a5bc64c2 100644
> --- a/src/include/com.h
> +++ b/src/include/com.h
> @@ -38,6 +38,7 @@
>  #  include <winsock2.h>
>  #else
>  #  include <sys/types.h>
> +#  include <sys/select.h>
>  #  include <sys/socket.h>
>  #  include <sys/un.h>
>  #  include <netinet/in.h>
> 
> -- 
> You received this message because you are subscribed to the Google Groups 
> "FriCAS - computer algebra system" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to [email protected].
> To view this discussion on the web visit 
> https://groups.google.com/d/msgid/fricas-devel/2d19b339-ef4d-4bab-bc59-ff5bc3fdd8ef%40gmail.com.

-- 
                              Waldek Hebisch

-- 
You received this message because you are subscribed to the Google Groups 
"FriCAS - computer algebra system" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To view this discussion on the web visit 
https://groups.google.com/d/msgid/fricas-devel/ZUo7WCCkKK41z/QW%40fricas.org.

Reply via email to