On Tue, Jul 18, 2023 at 04:36:38AM +0200, Grégory Vanuxem wrote:
> Waldek,
>
> I think in your patch, from line 49
> + not(pv.v = qv.v) =>
> + smaller?(leadingCoefficient(p), 0$R)$R => 1
> + -- pv.v = qv.v
>
> Should read
> + not(pv.v = qv.v) =>
> + smaller?(leadingCoefficient(p), 0$R)$R => 1
> + - 1
> + -- pv.v = qv.v
>
> Or something like that. All tests pass with this modification.
Yes, thanks. This should have triggered error in Spad compiler
(wrong return type), but has not...
Now one can test speed. Simple test could be:
pF := PF(nextPrime(2000000))
lp := [x - random()$pF for i in 1..84];
)set messages time on
sort(smaller?, lp);
[sort(smaller?, lp) for i in 1..10000];
Current version needs 2.55 sec for the last loop. With the patch
this drops to 0.69 sec.
--
Waldek Hebisch
--
You received this message because you are subscribed to the Google Groups
"FriCAS - computer algebra system" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/fricas-devel/ZLZzuq5XLHt/A2C7%40fricas.math.uni.wroc.pl.
