On Mon, May 15, 2023 at 07:36:06AM +0200, Ralf Hemmecke wrote:
> Thank you, Waldek, for the quick reaction.
>
> On 15.05.23 03:59, Waldek Hebisch wrote:
> > On Mon, May 15, 2023 at 12:47:37AM +0200, Ralf Hemmecke wrote:
> > > Thank you, Peter, for investing your time into this.
> > >
> > > Since this stuff concerns FriCAS code, I crosspost to fricas-devel.
> > >
> > > Obviously, Waldek missed some places while renaming $ to %.
> > >
> > > In my branch https://github.com/hemmecke/fricas/tree/dollar-percent
> > >
> > > https://github.com/hemmecke/fricas/commit/e7c4cca1aaa3e24951a9b826ffc0fdf9ab18586b.patch
> > >
> > > I have collected more suspicious places (where I have replaced $ by % --
> > > maybe not all correct, but should be considered).
> >
> > Quick comment about changes:
> >
> > 1) $$ is different than $, no need for replacement.
> > Similarly $$$ is different than $ and $$, no need for replacement.
>
> I wasn't sure, but AFAICS, Aldor also uses %% in categories. Maybe $$ and
> $$$ are future candidates for replacements.
I suspect that Aldor use of %% is different than our $$. And we use
%%, but for printing single %.
> > So changes to br-data.boot, compiler.boot, define.boot, modemap.boot,
> > nruncomp.boot, nrunfast.boot, nrungo.boot, nrunopt.boot,
> > i-map.boot, i-spec1.boot, i-spec2.boot, third and fifth
> > change to interop.boot, are not needed
> >
> > 2) in format.boot second change is wrong, we want $ here.
> > AFAICS formatOpConstant is unused, so better remove it.
> > Third change looks good.
> > Similarly, first change to i-output.boot is wrong (second is good).
> >
> > 3) I am not sure about change to trace.boot, but it is likely to
> > be wrong.
> >
> > 4) For Aldor you probably only need changes to as.boot and 3 of the
> > changes to interop.boot.
>
> In fact, I am not sure whether as.boot is used at all. For the FriCAS-Aldor
> interface ax.boot is used, but what as.boot is needed for, I have no clue.
Hmm, AFAICS ax.boot is for "exporting" info to Aldor, as.boot is to
get back info (databases) from Aldor. 'astran' should be called when
you do ')lib' on Aldor files. Parts of as.boot apparently are unused,
but since I can not test I did not try to remove them.
> I'll try to prepare a proper (tested) pull-request for "$ --> % renaming".
--
Waldek Hebisch
--
You received this message because you are subscribed to the Google Groups
"FriCAS - computer algebra system" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/fricas-devel/20230515113639.xuvzoezy5o4e6qj4%40fricas.math.uni.wroc.pl.
