Qian, super! I actually wanted to ask you before about some instructions that I (and others) could do in their github fork in order to make a full build with every commit.
I don't understand what you mean by > we don't run a full build and full test before commit, most of time Before I push to the official fricas repo, I have of course committed to my local repository and run the compilation, the tests, and now even build the documentation. You certainly know well enough that a local commit can easily be undone, so it's not a question of commit or not, but whether it's pushed to the official gh repo. I think it would be a good idea if every one who wants to have something integrated into fricas must setup CI on his/her github fork and show the logs of the build and tests so that it is clear that everything is OK before it is merged into the official repo. But perhaps you take the lead since you are the most experienced person with that stuff. Ralf On 11/21/20 3:56 PM, Qian Yun wrote: > We have a discussion about Travis CI 3 years ago, now we have moved > to GitHub, I believe now it's time to have CI? > One point Waldek raised was "run test before commit". > > If we have CI support, and you commit in your own master repo before > merge into main repo, you can "run test before commit". > > For pull request, with CI we can run tests before commit. > > Even if we commit directly into repo, with CI we can find problems > more quickly. > > (Anyway, I assume we don't run a full build and full test before > commit, most of time, right? :-) > > So, if we all agree to add CI support, I'll post a simple CI script > for discussion, and we can add functionality gradually over time. -- You received this message because you are subscribed to the Google Groups "FriCAS - computer algebra system" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To view this discussion on the web visit https://groups.google.com/d/msgid/fricas-devel/1203afe7-1a04-af5c-438b-af75401e08f2%40hemmecke.org.
