This patch simplifies the root of "x^2+2*a*x+2*b=0":
(1) -> rhs first radicalSolve(x^2+2*a*x+2*b,x)
+------------+
| 2
- \|- 8 b + 4 a - 2 a
(1) -----------------------
2
Type: Expression(Integer)
to
(2) -> -sqrt(a^2-2*b)-a
+----------+
| 2
(2) - \|- 2 b + a - a
Type: Expression(Integer)
by using sqaure-free factorization of Expression.
https://github.com/oldk1331/fricas/commit/650e788da9c5247658db6115f80bc068f68ff870.patch
diff --git a/ChangeLog b/ChangeLog
index 160f1cf9..66bea43d 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2019-04-08 Qian Yun <[email protected]>
+
+ * src/algebra/solvefor.spad, src/algebra/solverad.spad:
+ simplify square root in 'radicalSolve'
+
2019-04-08 Qian Yun <[email protected]>
* src/algebra/solvefor.spad: remove unused 'mapSolve'
diff --git a/src/algebra/solvefor.spad b/src/algebra/solvefor.spad
index 2bab4943..dab31527 100644
--- a/src/algebra/solvefor.spad
+++ b/src/algebra/solvefor.spad
@@ -1,6 +1,8 @@
)abbrev package SOLVEFOR PolynomialSolveByFormulas
--- Examples of fields with "^": (%, Fraction Integer) -> % are
--- Complex Float, RealClosure(K) and AlgebraicNumber
+-- Examples of \spadtype{F} (fields with "^" : (%, Fraction Integer) -> %)
are
+-- Expression Integer, Complex Float, RealClosure(K) and
AlgebraicNumber
+-- If \spadtype{F} is Expression(RR), you should put \spadtype{RR} as
+-- the third argument to this package for simplification purposes.
-- RealClosure(K) is unlikly to work here...
++ Author: Stephen M. Watt, Barry Trager
++ Description:
@@ -9,10 +11,11 @@
++ Care is taken to introduce few radicals so that radical extension
++ domains can more easily simplify the results.
-PolynomialSolveByFormulas(UP, F) : PSFcat == PSFdef where
+PolynomialSolveByFormulas(UP, F, RR) : PSFcat == PSFdef where
UP : UnivariatePolynomialCategory F
F : Field with "^": (%, Fraction Integer) -> %
+ RR : Join(PolynomialFactorizationExplicit, Comparable,
CharacteristicZero)
L ==> List
@@ -55,6 +58,23 @@
part(s : F) : F ==
s
+ -- if F is Expression(RR), then we can simplify "s^(1/2)" to
+ -- "a*b^(1/2)" by sqaure-free factorization. Note that we should
+ -- the unit separately; and the sign of "a" is not important --
+ -- we will return both roots later.
+ sqrt2(s : F) : F ==
+ if F is Expression RR then
+ smpsqfr := squareFree numer s
+ a : F := coerce("*"/[f.factor^(f.exponent quo 2) for f in
factorList smpsqfr])
+ b : F := coerce("*"/[f.factor^(f.exponent rem 2) for f in
factorList smpsqfr])
+ u : RR := retract(coerce(unit smpsqfr)@F)
+ sqfru := squareFree u
+ ua := "*"/[f.factor^(f.exponent quo 2) for f in factorList
sqfru]
+ ub := "*"/[f.factor^(f.exponent rem 2) for f in factorList
sqfru]
+ ua*a*sqrt(ub*b)
+ else
+ s^(1/2)
+
-----------------------------------------------------------------
-- Entry points and error handling
-----------------------------------------------------------------
@@ -139,7 +159,7 @@
needLcoef c2; needChar0()
(c0 = 0) => cons(0$F, linear(c2, c1))
(c1 = 0) => [(-c0/c2)^(1/2), -(-c0/c2)^(1/2)]
- D := part(c1^2 - 4*c2*c0)^(1/2)
+ D := sqrt2(c1^2 - 4*c2*c0)
[(-c1+D)/(2*c2), (-c1-D)/(2*c2)]
aQuadratic(c2, c1, c0) ==
diff --git a/src/algebra/solverad.spad b/src/algebra/solverad.spad
index 46a5cf7b..50fba034 100644
--- a/src/algebra/solverad.spad
+++ b/src/algebra/solverad.spad
@@ -76,7 +76,7 @@
L ==> List
P ==> Polynomial
- SOLVEFOR ==> PolynomialSolveByFormulas(SUP RE, RE)
+ SOLVEFOR ==> PolynomialSolveByFormulas(SUP RE, RE, R)
UPF2 ==> SparseUnivariatePolynomialFunctions2(PR, RE)
Cat ==> with
diff --git a/src/input/bugs2019.input b/src/input/bugs2019.input
index f3268439..db664c40 100644
--- a/src/input/bugs2019.input
+++ b/src/input/bugs2019.input
@@ -20,4 +20,9 @@ testEquals("factor(x-1)*0", "0")
testEquals("gcd(factor(x-1), 1)", "1")
testEquals("factor(x^2-1)+1-x^2", "0")
+testcase "simplification of square root in 'radicalSolve'"
+
+testEquals("rhs first radicalSolve(x^2+2*a*x+2*b,x)", "-sqrt(a^2-2*b)-a")
+testEquals("rhs first radicalSolve(x^2+2*a*c*x+2*b*c^2,x)",
"-c*sqrt(a^2-2*b)-a*c")
+
statistics()
--
You received this message because you are subscribed to the Google Groups
"FriCAS - computer algebra system" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
To post to this group, send email to [email protected].
To view this discussion on the web visit
https://groups.google.com/d/msgid/fricas-devel/CAGBJN904eVcB-Wy5Xxi2V4oFxpqMFGpJs1Xa6yuiXyCdYGOSyQ%40mail.gmail.com.
For more options, visit https://groups.google.com/d/optout.
