I don't see why we should not use __WIN32__ macro:

1. It will be a long time till Microsoft deprecate WIN32, even
after that, I'm sure MS will maintain backwards compatibility for
a long time.

2. In order to have better cross platform support, WIN32 is unavoidable.

3. BTW, MS has deprecated "mkdir", use "_mkdir" instead.

On 10/14/18 12:20 AM, Waldek Hebisch wrote:
> I have read what MinGW people wrote: they suggest puting WIN32
> in condition.  For now that would probably work, but I do
> not like.  One reasin is because Microsoft some day may decide
> that Windows (they seem to call all their OS products Windows)
> is no longer WIN32 and break it that way.  For me its looks
> better to test which variant compiles -- after all we do not
> care if system is Windows or not but if 'mkdir' with two
> arguments works or not.  Given that test is try to compile
> our code, I am tempted to add somwhat evil logic to Makefile:
>
> - try to compile two argument version, if it works use the resulting
>    object file
> - if first step failed, try one argument version, it it compiles
>    ose the resulting object file
> - if both compiles above failed issue error message and fail
>    (which normally stops build)
>

-- 
You received this message because you are subscribed to the Google Groups 
"FriCAS - computer algebra system" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to [email protected].
To post to this group, send email to [email protected].
Visit this group at https://groups.google.com/group/fricas-devel.
For more options, visit https://groups.google.com/d/optout.

Reply via email to