> > Misc cleanups > > https://github.com/oldk1331/fricas/commit/c373da5ded4f7f85739093105664b165b89fff94.patch >
Comments: In 'iroot' the original code uses 'not' to limit number of function calls, your change to '>=' adds extra call. AFAICS 'smaller?' was used to keep this function as similar as possible to the other case (that is parts that are doing the same thing have the same code). In 'minPoly' you are looking at arguments of k before checking that you have kernel with arguments -- that is wrong. Original code is correct. ATM I would keep Open Math part "as is". This is non-working (some crucial parts are missing) and currently unused code. We would like to get it working some day, so we keep it. I did some changes to the code to avoid troubles in Spad compiler, but otherwise it makes no sense to change it. > > Replace '"append"/' with 'concat' > > https://github.com/oldk1331/fricas/commit/f4909fd49add27b006db4e11476e9071a58ab680.patch Why? > Use 'gcd/lcm' instead of 'reduce' > > https://github.com/oldk1331/fricas/commit/39b4c422e77d0d8e75ba87c310f60758e298a9b6.patch Again why? -- Waldek Hebisch -- You received this message because you are subscribed to the Google Groups "FriCAS - computer algebra system" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected]. Visit this group at https://groups.google.com/group/fricas-devel. For more options, visit https://groups.google.com/d/optout.
