URL: https://github.com/freeipa/freeipa/pull/782
Author: felipevolpone
Title: #782: [WIP] Improving GUI text in "Add DNS Zones" popup
Action: opened
PR body:
"""
Improving usability of the "Add DNS Zones" popup in Web UI.
Ticket: https://pagure.io/freeipa/issue/6687
"""
To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/782/head:pr782
git checkout pr782
From 776528aec528c2169214929e892a225bb088af5d Mon Sep 17 00:00:00 2001
From: Felipe Volpone <felipevolp...@gmail.com>
Date: Thu, 11 May 2017 20:16:31 -0300
Subject: [PATCH] Improving GUI text in "Add DNS Zones" popup
---
install/ui/src/freeipa/dns.js | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/install/ui/src/freeipa/dns.js b/install/ui/src/freeipa/dns.js
index 1be8513..f2b110d 100644
--- a/install/ui/src/freeipa/dns.js
+++ b/install/ui/src/freeipa/dns.js
@@ -294,6 +294,11 @@ return {
height: 300,
sections: [
{
+ name: 'dnszone_title',
+ label: 'Select the required zone type.',
+ fields: []
+ },
+ {
name: 'name',
layout: IPA.dnszone_name_section_layout,
fields: [
@@ -307,6 +312,7 @@ return {
$type: 'dnszone_name',
name: 'name_from_ip',
radio_name: 'dnszone_name_type',
+ required: false,
validators: ['network']
}
]
@@ -750,9 +756,6 @@ IPA.add_dns_zone_name_policy = function() {
idnsname_w.input.prop('disabled', false);
name_from_ip_w.input.prop('disabled', true);
- idnsname_f.set_required(true);
- name_from_ip_f.set_required(false);
-
name_from_ip_f.reset();
});
@@ -760,9 +763,6 @@ IPA.add_dns_zone_name_policy = function() {
idnsname_w.input.prop('disabled', true);
name_from_ip_w.input.prop('disabled', false);
- idnsname_f.set_required(false);
- name_from_ip_f.set_required(true);
-
idnsname_f.reset();
});
};
--
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
