URL: https://github.com/freeipa/freeipa/pull/725
Author: Akasurde
 Title: #725: Fix certificate_out check in CertRetrieveOverride
Action: opened

PR body:
"""
Fixes: https://pagure.io/freeipa/issue/6885

Signed-off-by: Abhijeet Kasurde <akasu...@redhat.com>
"""

To pull the PR as Git branch:
git remote add ghfreeipa https://github.com/freeipa/freeipa
git fetch ghfreeipa pull/725/head:pr725
git checkout pr725
From b324d3250c6455afd8bdbf71cd09496344dab40d Mon Sep 17 00:00:00 2001
From: Abhijeet Kasurde <akasu...@redhat.com>
Date: Fri, 21 Apr 2017 10:04:19 +0530
Subject: [PATCH] Fix certificate_out check in CertRetrieveOverride

Fixes: https://pagure.io/freeipa/issue/6885

Signed-off-by: Abhijeet Kasurde <akasu...@redhat.com>
---
 ipaclient/plugins/cert.py | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/ipaclient/plugins/cert.py b/ipaclient/plugins/cert.py
index a4ee9a9..78b7e29 100644
--- a/ipaclient/plugins/cert.py
+++ b/ipaclient/plugins/cert.py
@@ -50,8 +50,7 @@ class CertRetrieveOverride(MethodOverride):
 
     def forward(self, *args, **options):
         certificate_out = options.pop('certificate_out', None)
-        if certificate_out is not None:
-            util.check_writable_file(certificate_out)
+        util.check_writable_file(certificate_out)
 
         result = super(CertRetrieveOverride, self).forward(*args, **options)
 
-- 
Manage your subscription for the Freeipa-devel mailing list:
https://www.redhat.com/mailman/listinfo/freeipa-devel
Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code

Reply via email to