URL: https://github.com/freeipa/freeipa/pull/224 Author: ofayans Title: #224: Integration tests for certs in idoverrides Action: opened
PR body: """ Original mailing list thread: https://www.redhat.com/archives/freeipa-devel/2016-September/msg00134.html """ To pull the PR as Git branch: git remote add ghfreeipa https://github.com/freeipa/freeipa git fetch ghfreeipa pull/224/head:pr224 git checkout pr224
From c0faf1d8263c11d110a63b912c82a74e2f04a4d8 Mon Sep 17 00:00:00 2001 From: Oleg Fayans <[email protected]> Date: Tue, 6 Sep 2016 12:39:45 +0200 Subject: [PATCH 1/2] Added interface to certutil --- ipatests/test_integration/tasks.py | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/ipatests/test_integration/tasks.py b/ipatests/test_integration/tasks.py index df5e408..dcf9ab8 100644 --- a/ipatests/test_integration/tasks.py +++ b/ipatests/test_integration/tasks.py @@ -1207,6 +1207,13 @@ def run_server_del(host, server_to_delete, force=False, return host.run_command(args, raiseonerr=False) +def run_certutil(host, args, reqdir, stdin=None, raiseonerr=True): + new_args = [paths.CERTUTIL, "-d", reqdir] + new_args = " ".join(new_args + args) + return host.run_command(new_args, raiseonerr=raiseonerr, + stdin_text=stdin) + + def assert_error(result, stderr_text, returncode=None): "Assert that `result` command failed and its stderr contains `stderr_text`" assert stderr_text in result.stderr_text, result.stderr_text From 8967612df5461669862f2609bdf69ecf7d1a0901 Mon Sep 17 00:00:00 2001 From: Oleg Fayans <[email protected]> Date: Thu, 10 Nov 2016 10:32:41 +0100 Subject: [PATCH 2/2] Test: integration tests for certs in idoverrides feature https://fedorahosted.org/freeipa/ticket/6005 --- ipatests/test_integration/test_idviews.py | 156 ++++++++++++++++++++++++++++++ 1 file changed, 156 insertions(+) create mode 100644 ipatests/test_integration/test_idviews.py diff --git a/ipatests/test_integration/test_idviews.py b/ipatests/test_integration/test_idviews.py new file mode 100644 index 0000000..c35997c --- /dev/null +++ b/ipatests/test_integration/test_idviews.py @@ -0,0 +1,156 @@ +# +# Copyright (C) 2016 FreeIPA Contributors see COPYING for license +# + +import os +import re +import string +from ipatests.test_integration import tasks +from ipatests.test_integration.base import IntegrationTest +from ipatests.test_integration.env_config import get_global_config +from ipaplatform.paths import paths +config = get_global_config() + + +class TestCertsInIDOverrides(IntegrationTest): + topology = "line" + num_ad_domains = 1 + adview = 'Default Trust View' + cert_re = re.compile('Certificate: (?P<cert>.*?)\\s+.*') + adcert1 = 'MyCert1' + adcert2 = 'MyCert2' + adcert1_file = adcert1 + '.crt' + adcert2_file = adcert2 + '.crt' + + @classmethod + def uninstall(cls, mh): + super(TestCertsInIDOverrides, cls).uninstall(mh) + cls.master.run_command(['rm', '-rf', cls.reqdir], raiseonerr=False) + + @classmethod + def install(cls, mh): + super(TestCertsInIDOverrides, cls).install(mh) + cls.ad = config.ad_domains[0].ads[0] + cls.ad_domain = cls.ad.domain.name + cls.aduser = "testuser@%s" % cls.ad_domain + + master = cls.master + # A setup for test_dbus_user_lookup + master.run_command(['dnf', 'install', '-y', 'sssd-dbus'], + raiseonerr=False) + # The tasks.modify_sssd_conf way did not work because + # sssd_domain.set_option knows nothing about 'services' parameter of + # the sssd config file. Therefore I am using sed approach + master.run_command( + "sed -i '/^services/ s/$/, ifp/' %s" % paths.SSSD_CONF) + master.run_command( + "sed -i 's/= 7/= 0xFFF0/' %s" % paths.SSSD_CONF, raiseonerr=False) + master.run_command(['systemctl', 'restart', 'sssd.service']) + # End of setup for test_dbus_user_lookup + + # AD-related stuff + tasks.install_adtrust(master) + tasks.sync_time(master, cls.ad) + tasks.establish_trust_with_ad(cls.master, cls.ad_domain, + extra_args=['--range-type', + 'ipa-ad-trust']) + + cls.reqdir = os.path.join(master.config.test_dir, "certs") + cls.reqfile1 = os.path.join(cls.reqdir, "test1.csr") + cls.reqfile2 = os.path.join(cls.reqdir, "test2.csr") + cls.pwname = os.path.join(cls.reqdir, "pwd") + + # Create a NSS database folder + master.run_command(['mkdir', cls.reqdir], raiseonerr=False) + # Create an empty password file + master.run_command(["touch", cls.pwname], raiseonerr=False) + + # Initialize NSS database + tasks.run_certutil(master, ["-N", "-f", cls.pwname], cls.reqdir) + # Now generate self-signed certs for a windows user + stdin_text = string.digits+string.letters[2:] + '\n' + tasks.run_certutil(master, ['-S', '-s', + "cn=%s,dc=ad,dc=test" % cls.adcert1, '-n', + cls.adcert1, '-x', '-t', 'CT,C,C', '-v', + '120', '-m', '1234'], + cls.reqdir, stdin=stdin_text) + tasks.run_certutil(master, ['-S', '-s', + "cn=%s,dc=ad,dc=test" % cls.adcert2, '-n', + cls.adcert2, '-x', '-t', 'CT,C,C', '-v', + '120', '-m', '1234'], + cls.reqdir, stdin=stdin_text) + + # Export the previously generated cert + tasks.run_certutil(master, ['-L', '-n', cls.adcert1, '-a', '>', + cls.adcert1_file], cls.reqdir) + tasks.run_certutil(master, ['-L', '-n', cls.adcert2, '-a', '>', + cls.adcert2_file], cls.reqdir) + cls.cert1_base64 = cls.master.run_command( + "openssl x509 -outform der -in %s | base64 -w 0" % cls.adcert1_file + ).stdout_text + cls.cert2_base64 = cls.master.run_command( + "openssl x509 -outform der -in %s | base64 -w 0" % cls.adcert2_file + ).stdout_text + cls.cert1_pem = cls.master.run_command( + "openssl x509 -in %s -outform pem" % cls.adcert1_file + ).stdout_text + cls.cert2_pem = cls.master.run_command( + "openssl x509 -in %s -outform pem" % cls.adcert2_file + ).stdout_text + + def test_certs_in_idoverrides_ad_users(self): + """ + http://www.freeipa.org/page/V4/Certs_in_ID_overrides/Test_Plan + #Test_case:_Manipulate_certificate_in_ID_override_entry + """ + master = self.master + master.run_command(['ipa', 'idoverrideuser-add', + self.adview, self.aduser]) + master.run_command(['ipa', 'idoverrideuser-add-cert', + self.adview, self.aduser, + "--certificate=%s" % self.cert1_base64]) + master.run_command(['ipa', 'idoverrideuser-add-cert', + self.adview, self.aduser, + "--certificate=%s" % self.cert2_base64]) + result = master.run_command(['ipa', 'idoverrideuser-show', + self.adview, self.aduser]) + assert(self.cert1_base64 in result.stdout_text and + self.cert2_base64 in result.stdout_text), ( + "idoverrideuser-show does not show all user certificates") + master.run_command(['ipa', 'idoverrideuser-remove-cert', + self.adview, self.aduser, + "--certificate=%s" % self.cert2_base64]) + + def test_dbus_user_lookup(self): + """ + http://www.freeipa.org/page/V4/Certs_in_ID_overrides/Test_Plan + #Test_case:_User_lookup_by_certificate + """ + + master = self.master + userpath_re = re.compile('.*object path "(.*?)".*') + + result0 = master.run_command([ + 'dbus-send', '--system', '--print-reply', + '--dest=org.freedesktop.sssd.infopipe', + '/org/freedesktop/sssd/infopipe/Users', + 'org.freedesktop.sssd.infopipe.Users.FindByCertificate', + "string:%s" % self.cert1_pem]) + assert("object path" in result0.stdout_text), ( + "command output did not contain expected" + "string:\n\n%s" % result0.stdout_text) + userpath = userpath_re.findall(result0.stdout_text)[0] + result1 = master.run_command( + "dbus-send --system --print-reply" + " --dest=org.freedesktop.sssd.infopipe" + " %s org.freedesktop.DBus.Properties.Get" + " string:\"org.freedesktop.sssd.infopipe.Users.User\"" + " string:\"name\"" % userpath, raiseonerr=False) + assert(self.aduser in result1.stdout_text) + result2 = master.run_command( + "dbus-send --system --print-reply" + " --dest=org.freedesktop.sssd.infopipe" + " %s org.freedesktop.DBus.Properties.GetAll" + " string:\"org.freedesktop.sssd.infopipe.Users.User\"" % userpath + ) + assert('dict entry' in result2.stdout_text)
-- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
