On (05/08/16 12:43), Petr Vobornik wrote: >On 07/28/2016 01:01 PM, Martin Basti wrote: >> >> >> On 25.07.2016 11:46, Simo Sorce wrote: >>> The attached patches fix some minor issues found by coverity, and pull >>> in other fixes released by the asn1c project. >>> >>> Simo. >>> >>> >>> >> I cannot build RPMS with this patch, is there any missing build dependency? >> >> /bin/sh ./libtool --tag=CC --mode=link gcc -Wall -Wshadow >> -Wstrict-prototypes -Wpointer-arith -Wcast-align >> -Werror-implicit-function-declaration -O2 -g -pipe -Wall >> -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions >> -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches >> -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic -g -O2 >> -Wall >> -Wextra -Wformat-security -Wno-unused-parameter -Wno-sign-compare >> -Wno-missing-field-initializers -Wl,-z,relro >> -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -o ipa-getkeytab >> ipa-getkeytab.o >> ipa-client-common.o ipa_krb5.o ../asn1/libipaasn1.la -lkrb5 -lk5crypto >> -lcom_err >> -llber -lldap -lsasl2 -lpopt -lini_config -lbasicobjects -lref_array >> -lcollection -lini_config -lini_config >> libtool: link: gcc -Wall -Wshadow -Wstrict-prototypes -Wpointer-arith >> -Wcast-align -Werror-implicit-function-declaration -O2 -g -pipe -Wall >> -Werror=format-security -Wp,-D_FORTIFY_SOURCE=2 -fexceptions >> -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches >> -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -m64 -mtune=generic -g -O2 >> -Wall >> -Wextra -Wformat-security -Wno-unused-parameter -Wno-sign-compare >> -Wno-missing-field-initializers -Wl,-z -Wl,relro >> -specs=/usr/lib/rpm/redhat/redhat-hardened-ld -o ipa-getkeytab >> ipa-getkeytab.o >> ipa-client-common.o ipa_krb5.o ../asn1/.libs/libipaasn1.a -lkrb5 -lk5crypto >> -lcom_err -llber -lldap -lsasl2 -lpopt -lbasicobjects -lref_array >> -lcollection >> -lini_config >> ../asn1/.libs/libipaasn1.a(constr_CHOICE.o): In function >> `CHOICE_decode_uper': >> /root/freeipa/rpmbuild/BUILD/freeipa-4.4.0/asn1/asn1c/constr_CHOICE.c:897: >> undefined reference to `uper_open_type_get' >> ../asn1/.libs/libipaasn1.a(constr_CHOICE.o): In function >> `CHOICE_encode_uper': >> /root/freeipa/rpmbuild/BUILD/freeipa-4.4.0/asn1/asn1c/constr_CHOICE.c:982: >> undefined reference to `uper_open_type_put' >> ../asn1/.libs/libipaasn1.a(constr_SEQUENCE.o): In function >> `SEQUENCE_handle_extensions': >> /root/freeipa/rpmbuild/BUILD/freeipa-4.4.0/asn1/asn1c/constr_SEQUENCE.c:1285: >> >> undefined reference to `uper_open_type_put' >> ../asn1/.libs/libipaasn1.a(constr_SEQUENCE.o): In function >> `SEQUENCE_decode_uper': >> /root/freeipa/rpmbuild/BUILD/freeipa-4.4.0/asn1/asn1c/constr_SEQUENCE.c:1187: >> >> undefined reference to `uper_open_type_get' >> /root/freeipa/rpmbuild/BUILD/freeipa-4.4.0/asn1/asn1c/constr_SEQUENCE.c:1203: >> >> undefined reference to `uper_open_type_skip' >> collect2: error: ld returned 1 exit status >> >> Martin^2 >> > >Bumping. Was it temporary issue or issue in the patch? > I could not see such error. However, these patches would be good to test with coverity. We need to use fedora rawhide for testing due to BuildRequires in freeipa.spec. But C-part of freeIPA cannot be compiled on rawhide due to new samba (4.5). Patches are already on the list.
LS -- Manage your subscription for the Freeipa-devel mailing list: https://www.redhat.com/mailman/listinfo/freeipa-devel Contribute to FreeIPA: http://www.freeipa.org/page/Contribute/Code
