On Tue, 2011-11-29 at 10:39 -0500, Rob Crittenden wrote: > Martin Kosek wrote: > > On Mon, 2011-11-14 at 10:37 +0100, Martin Kosek wrote: > >> On Fri, 2011-11-11 at 10:22 -0500, Rob Crittenden wrote: > >>> Martin Kosek wrote: > >>>> There are 2 patches improving our zone zonemgr: > >>>> > >>>> 1) ipa-server-install --zonemgr option validation and normalization + > >>>> the same thing in ipa dnszone-add/mod --admin-email. They now allow and > >>>> correctly process '.' in a local-part of the zonemgr e-mail (it is > >>>> encoded as '\.'. > >>>> > >>>> How to test: > >>>> > >>>> ipa-server-install -p secret123 -a secret123 --setup-dns > >>>> [email protected] > >>>> OR if e-mail is passed in SOA format: > >>>> ipa-server-install -p secret123 -a secret123 --setup-dns > >>>> --zonemgr='foo\.bar.example.com' > >>>> > >>>> In both cases, the zonemgr e-mail will be set to correct format: 'foo > >>>> \.bar.example.com'. > >>>> > >>>> 2) Our default zonemgr is changed to follow RFC 2142 recommendation - > >>>> hostmaster@<domain> > >>>> > >>>> hostmaster is an alias to root anyway (see /etc/aliases). > >>>> > >>>> Martin > >>> > >>> NACK 166, this illegal address is allowed: foo\.bar\.baz\.com > >>> > >>> ACK 167 when 166 is ready. > >>> > >>> rob > >> > >> Are you sure that you quoted the string in shell properly? It likes to > >> eat backslashes when one is not cautious. The zonemgr value, including > >> backslashes, should then show up in `ipa dnszone-show ZONE'. > >> > >> This is my output: > >> > >> # ipa dnszone-mod example.com --admin-email='foo\.bar\.baz\.com' > >> ipa: ERROR: invalid 'admin_email': address domain is not fully qualified > >> ("example.com" instead of just "example") > >> > >> Anyway, attaching a rebased patch (it collided with my patch 120). > >> > >> Martin > > > > I rebased both patches. I also fixed a bug when ipa-replica-prepare > > $HOST --ip-address=$IP was failing because None was passed as zonemgr. > > > > Martin > > > $ ./make-lint > ipaserver/install/bindinstance.py:392: [E0602, BindInstance.setup] > Undefined variable 'normalize_zonemgr' > > Fixed with: > > --- a/ipaserver/install/bindinstance.py > +++ b/ipaserver/install/bindinstance.py > @@ -32,7 +32,7 @@ from ipapython import sysrestore > from ipapython import ipautil > from ipalib.constants import DNS_ZONE_REFRESH > from ipalib.parameters import IA5Str > -from ipalib.util import validate_zonemgr > +from ipalib.util import validate_zonemgr, normalize_zonemgr > from ipapython.ipa_log_manager import * > > import ipalib > > ACK for both with this import fixed. > > rob
Good catch. This must have been some late fix again. Fixed. Both patches pushed to master. Martin _______________________________________________ Freeipa-devel mailing list [email protected] https://www.redhat.com/mailman/listinfo/freeipa-devel
