On Tue, 2011-09-13 at 09:58 -0400, Rob Crittenden wrote: > Martin Kosek wrote: > > On Fri, 2011-09-09 at 17:41 -0400, Rob Crittenden wrote: > >> - Remove ipa-pki-proxy.conf when IPA is uninstalled > >> - Move file removal to httpinstance.py and use remove_file() > >> - Add a version stanza > >> - Create the file if it doesn't exist on upgraded installs > >> > >> https://fedorahosted.org/freeipa/ticket/1771 > >> > >> rob > > > > Both upgrade and new install worked fine. I only find the following > > try..except clause redundant since all exceptions are captured and > > logged in installutils.remove_file: > > > > + # Remove the configuration files we create > > + try: > > + installutils.remove_file("/etc/httpd/conf.d/ipa-rewrite.conf") > > + installutils.remove_file("/etc/httpd/conf.d/ipa.conf") > > + > > installutils.remove_file("/etc/httpd/conf.d/ipa-pki-proxy.conf") > > + except: > > + pass > > > > Martin > > > > Updated patch attached > > rob
ACK. Pushed to master, ipa-2-1. I didn't close the ticket as I saw that this patch is not a complete solution. Martin _______________________________________________ Freeipa-devel mailing list Freeipa-devel@redhat.com https://www.redhat.com/mailman/listinfo/freeipa-devel
