Jessica Zhang <quic_jessz...@quicinc.com> 于2025年5月9日周五 04:55写道： > > > > On 5/8/2025 1:42 PM, Jessica Zhang wrote: > > > > > > On 5/6/2025 8:47 AM, Jun Nie wrote: > >> The stage contains configuration for a mixer pair. Currently the plane > >> supports just one stage and 2 pipes. Quad-pipe support will require > >> handling 2 stages and 4 pipes at the same time. In preparation for that > >> add a separate define, PIPES_PER_PLANE, to denote number of pipes that > >> can be used by the plane. > >> > >> Signed-off-by: Jun Nie <jun....@linaro.org> > >> Reviewed-by: Dmitry Baryshkov <dmitry.barysh...@linaro.org> > > > > Hi Jun, > > > > I think the comment from v7 about propogating the PIPES_PER_PLANE change > > to _dpu_plane_color_fill() got dropped in this version [1]. > > s/propogating/propagating/ > > > > > Also, any reason PIPES_PER_STAGE was kept for > > dpu_plane_danger_signal_ctrl()? > > I have the same question for _dpu_debugfs_status_show(). It seems to me > both helpers should be using PIPES_PER_PLANE. > > Thanks, > > Jessica Zhang > Thanks for pointing this out! They both should be changed to PIPES_PER_PLANE. Will fix it in next version.
Jun
