Re: [PATCH v4 06/16] drm/msm/dp: split MMSS_DP_DSC_DTO register write to a separate function

[Abhinav Kumar]

On 12/16/2024 2:24 PM, Dmitry Baryshkov wrote:
On Mon, Dec 16, 2024 at 11:46:21AM -0800, Abhinav Kumar wrote:


On 12/15/2024 2:44 PM, Dmitry Baryshkov wrote:
It's the dp_panel's duty to clear the MMSS_DP_DSC_DTO register. Once DP
driver gets DSC support, it will handle that register in other places
too. Split a call to write 0x0 to that register to a separate function.

Signed-off-by: Dmitry Baryshkov <dmitry.barysh...@linaro.org>
---
   drivers/gpu/drm/msm/dp/dp_catalog.c | 8 ++++++++
   drivers/gpu/drm/msm/dp/dp_catalog.h | 2 ++
   drivers/gpu/drm/msm/dp/dp_ctrl.c    | 2 ++
   3 files changed, 12 insertions(+)

diff --git a/drivers/gpu/drm/msm/dp/dp_catalog.c 
b/drivers/gpu/drm/msm/dp/dp_catalog.c
index 
7b7eadb2f83b169d8df27ee93589abe05b38f3ae..354ec834f9357c4797fc08a4532e69acc67b4317
 100644
--- a/drivers/gpu/drm/msm/dp/dp_catalog.c
+++ b/drivers/gpu/drm/msm/dp/dp_catalog.c
@@ -1039,6 +1039,14 @@ void msm_dp_catalog_panel_tpg_disable(struct 
msm_dp_catalog *msm_dp_catalog)
        msm_dp_write_p0(catalog, MMSS_DP_TIMING_ENGINE_EN, 0x0);
   }
+void msm_dp_catalog_panel_clear_dsc_dto(struct msm_dp_catalog *msm_dp_catalog)
+{
+       struct msm_dp_catalog_private *catalog = container_of(msm_dp_catalog,
+                               struct msm_dp_catalog_private, msm_dp_catalog);
+
+       msm_dp_write_p0(catalog, MMSS_DP_DSC_DTO, 0x0);
+}

This is already done msm_dp_catalog_ctrl_config_msa(), this is either a
duplicate or redundant.

void msm_dp_catalog_ctrl_config_msa(..........)
{
        **********
         msm_dp_write_link(catalog, REG_DP_SOFTWARE_NVID, nvid);
         msm_dp_write_p0(catalog, MMSS_DP_DSC_DTO, 0x0);
}

The chunk to remove it got squashed into a different patch.


hmm, if you would indeed like it to be a separate API , the removal from 
the above chunk should go together in the same patch otherwise it looks 
redundant.


+
   static void __iomem *msm_dp_ioremap(struct platform_device *pdev, int idx, 
size_t *len)
   {
        struct resource *res;
diff --git a/drivers/gpu/drm/msm/dp/dp_catalog.h 
b/drivers/gpu/drm/msm/dp/dp_catalog.h
index 
6678b0ac9a67881244884d59487fa288d33d1be7..08bb42e91b779633875dbeb4130bc55a6571cfb1
 100644
--- a/drivers/gpu/drm/msm/dp/dp_catalog.h
+++ b/drivers/gpu/drm/msm/dp/dp_catalog.h
@@ -92,6 +92,8 @@ void msm_dp_catalog_panel_tpg_enable(struct msm_dp_catalog 
*msm_dp_catalog,
                                struct drm_display_mode *drm_mode);
   void msm_dp_catalog_panel_tpg_disable(struct msm_dp_catalog *msm_dp_catalog);
+void msm_dp_catalog_panel_clear_dsc_dto(struct msm_dp_catalog *msm_dp_catalog);
+
   struct msm_dp_catalog *msm_dp_catalog_get(struct device *dev);
   /* DP Audio APIs */
diff --git a/drivers/gpu/drm/msm/dp/dp_ctrl.c b/drivers/gpu/drm/msm/dp/dp_ctrl.c
index 
9c463ae2f8fae916661fef1c7e225f55c1026478..b9c461fee96f8fae9259ce03a32e1155b42d17bb
 100644
--- a/drivers/gpu/drm/msm/dp/dp_ctrl.c
+++ b/drivers/gpu/drm/msm/dp/dp_ctrl.c
@@ -2011,6 +2011,8 @@ int msm_dp_ctrl_on_stream(struct msm_dp_ctrl 
*msm_dp_ctrl, bool force_link_train
                pixel_rate_orig,
                ctrl->panel->msm_dp_mode.out_fmt_is_yuv_420);
+       msm_dp_catalog_panel_clear_dsc_dto(ctrl->catalog);
+
        msm_dp_ctrl_setup_tr_unit(ctrl);
        msm_dp_catalog_ctrl_state_ctrl(ctrl->catalog, DP_STATE_CTRL_SEND_VIDEO);