On Mon, 25 Nov 2024 at 04:31, fange zhang <quic_fan...@quicinc.com> wrote: > > > > On 2024/11/22 18:10, Dmitry Baryshkov wrote: > > On Fri, Nov 22, 2024 at 05:56:50PM +0800, Fange Zhang wrote: > >> From: Li Liu <quic_ll...@quicinc.com> > >> > >> Add support for DSI 2.3.1 (block used on SM6150). > >> > >> Signed-off-by: Li Liu <quic_ll...@quicinc.com> > >> Signed-off-by: Fange Zhang <quic_fan...@quicinc.com> > >> --- > >> drivers/gpu/drm/msm/dsi/dsi_cfg.c | 4 +++- > >> drivers/gpu/drm/msm/dsi/dsi_cfg.h | 1 + > >> 2 files changed, 4 insertions(+), 1 deletion(-) > >> > >> diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c > >> b/drivers/gpu/drm/msm/dsi/dsi_cfg.c > >> index > >> 10ba7d153d1cfc9015f527c911c4658558f6e29e..fe02724bddf69c2e8d6816589f4ea410fa666e5b > >> 100644 > >> --- a/drivers/gpu/drm/msm/dsi/dsi_cfg.c > >> +++ b/drivers/gpu/drm/msm/dsi/dsi_cfg.c > >> @@ -171,7 +171,7 @@ static const struct msm_dsi_config sdm845_dsi_cfg = { > >> .num_bus_clks = ARRAY_SIZE(dsi_v2_4_clk_names), > >> .io_start = { > >> { 0xae94000, 0xae96000 }, /* SDM845 / SDM670 */ > >> - { 0x5e94000 }, /* QCM2290 / SM6115 / SM6125 / SM6375 */ > >> + { 0x5e94000 }, /* QCM2290 / SM6115 / SM6125 / SM6150 / SM6375 > >> */ > > > > Not true > Should I remove it or add it behind the SDM670?
You should not be sending patches which provide false information. Why did you add it to the wrong line in the first place? > > > >> }, > >> }; > >> > >> @@ -286,6 +286,8 @@ static const struct msm_dsi_cfg_handler > >> dsi_cfg_handlers[] = { > >> &sdm845_dsi_cfg, &msm_dsi_6g_v2_host_ops}, > >> {MSM_DSI_VER_MAJOR_6G, MSM_DSI_6G_VER_MINOR_V2_3_0, > >> &sdm845_dsi_cfg, &msm_dsi_6g_v2_host_ops}, > >> + {MSM_DSI_VER_MAJOR_6G, MSM_DSI_6G_VER_MINOR_V2_3_1, > >> + &sdm845_dsi_cfg, &msm_dsi_6g_v2_host_ops}, > >> {MSM_DSI_VER_MAJOR_6G, MSM_DSI_6G_VER_MINOR_V2_4_0, > >> &sdm845_dsi_cfg, &msm_dsi_6g_v2_host_ops}, > >> {MSM_DSI_VER_MAJOR_6G, MSM_DSI_6G_VER_MINOR_V2_4_1, > >> diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.h > >> b/drivers/gpu/drm/msm/dsi/dsi_cfg.h > >> index > >> 4c9b4b37681b066dbbc34876c38d99deee24fc82..120cb65164c1ba1deb9acb513e5f073bd560c496 > >> 100644 > >> --- a/drivers/gpu/drm/msm/dsi/dsi_cfg.h > >> +++ b/drivers/gpu/drm/msm/dsi/dsi_cfg.h > >> @@ -23,6 +23,7 @@ > >> #define MSM_DSI_6G_VER_MINOR_V2_2_0 0x20000000 > >> #define MSM_DSI_6G_VER_MINOR_V2_2_1 0x20020001 > >> #define MSM_DSI_6G_VER_MINOR_V2_3_0 0x20030000 > >> +#define MSM_DSI_6G_VER_MINOR_V2_3_1 0x20030001 > >> #define MSM_DSI_6G_VER_MINOR_V2_4_0 0x20040000 > >> #define MSM_DSI_6G_VER_MINOR_V2_4_1 0x20040001 > >> #define MSM_DSI_6G_VER_MINOR_V2_5_0 0x20050000 > >> > >> -- > >> 2.34.1 > >> > > > -- With best wishes Dmitry