Re: [Freedreno] [PATCH v2 2/4] arm64: dts: qcom: qrb5165-rb5: add onboard USB-C redriver

[Bryan O'Donoghue]

On 17/08/2023 15:59, Dmitry Baryshkov wrote:

Add the nb7vpq904m, onboard USB-C redriver / retimer.

Signed-off-by: Dmitry Baryshkov <dmitry.barysh...@linaro.org>
---
  arch/arm64/boot/dts/qcom/qrb5165-rb5.dts | 52 +++++++++++++++++++++++-
  1 file changed, 50 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts 
b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
index 303d07f9c6e5..a4f7a9f9c22c 100644
--- a/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
+++ b/arch/arm64/boot/dts/qcom/qrb5165-rb5.dts
@@ -610,6 +610,46 @@ lt9611_out: endpoint {
  /* LS-I2C1 */
  &i2c15 {
        status = "okay";
+
+       typec-mux@1c {
+               compatible = "onnn,nb7vpq904m";
+               reg = <0x1c>;
+
+               vcc-supply = <&vreg_s4a_1p8>;
+
+               retimer-switch;
+               orientation-switch;
+
+               ports {
+                       #address-cells = <1>;
+                       #size-cells = <0>;
+
+                       port@0 {
+                               reg = <0>;
+
+                               redriver_usb_con_ss: endpoint {
+                                       remote-endpoint = 
<&pm8150b_typec_mux_in>;
+                               };
+                       };
+
+                       port@1 {
+                               reg = <1>;
+
+                               redriver_phy_con_ss: endpoint {
+                                       remote-endpoint = <&usb_1_qmpphy_out>;
+                                       data-lanes = <0 1 2 3>;
+                               };
+                       };
+
+                       port@2 {
+                               reg = <2>;
+
+                               redriver_usb_con_sbu: endpoint {
+                                       remote-endpoint = 
<&pm8150b_typec_sbu_out>;
+                               };
+                       };
+               };
+       };
  };

&mdss {

@@ -1299,7 +1339,7 @@ &usb_1_qmpphy {
  };

&usb_1_qmpphy_out {

-       remote-endpoint = <&pm8150b_typec_mux_in>;
+       remote-endpoint = <&redriver_phy_con_ss>;
  };

&usb_2 {

@@ -1388,7 +1428,15 @@ pm8150b_role_switch_in: endpoint {
                        port@1 {
                                reg = <1>;
                                pm8150b_typec_mux_in: endpoint {
-                                       remote-endpoint = <&usb_1_qmpphy_out>;
+                                       remote-endpoint = 
<&redriver_usb_con_ss>;
+                               };
+                       };
+
+                       port@2 {
+                               reg = <2>;
+
+                               pm8150b_typec_sbu_out: endpoint {
+                                       remote-endpoint = 
<&redriver_usb_con_sbu>;
                                };
                        };
                };

LGTM

Reviewed-by: Bryan O'Donoghue <bryan.odonog...@linaro.org>