> -----Original Message-----
> From: Stephen Boyd <swb...@chromium.org>
> Sent: Friday, March 18, 2022 2:58 AM
> To: Sankeerth Billakanti (QUIC) <quic_sbill...@quicinc.com>;
> devicet...@vger.kernel.org; dri-de...@lists.freedesktop.org;
> freedreno@lists.freedesktop.org; linux-arm-...@vger.kernel.org; linux-
> ker...@vger.kernel.org
> Cc: robdcl...@gmail.com; seanp...@chromium.org; quic_kalyant
> <quic_kaly...@quicinc.com>; Abhinav Kumar (QUIC)
> <quic_abhin...@quicinc.com>; diand...@chromium.org; Kuogee Hsieh
> (QUIC) <quic_khs...@quicinc.com>; agr...@kernel.org;
> bjorn.anders...@linaro.org; robh...@kernel.org; krzk...@kernel.org;
> s...@poorly.run; airl...@linux.ie; dan...@ffwll.ch;
> thierry.red...@gmail.com; s...@ravnborg.org;
> dmitry.barysh...@linaro.org; quic_vproddut <quic_vprod...@quicinc.com>
> Subject: Re: [PATCH v5 3/9] arm64: dts: qcom: sc7280: Enable backlight for
> eDP panel
>
> Quoting Sankeerth Billakanti (2022-03-16 10:35:48)
> > Enable backlight support for eDP panel on CRD platform for sc7280.
> >
> > Signed-off-by: Sankeerth Billakanti <quic_sbill...@quicinc.com>
> > ---
> >
> > Changes in v5:
> > - Separate out backlight nodes
> >
> > arch/arm64/boot/dts/qcom/sc7280-crd.dts | 18 ++++++++++++++++++
> > 1 file changed, 18 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sc7280-crd.dts
> > b/arch/arm64/boot/dts/qcom/sc7280-crd.dts
> > index 2df654e..16d1a5b 100644
> > --- a/arch/arm64/boot/dts/qcom/sc7280-crd.dts
> > +++ b/arch/arm64/boot/dts/qcom/sc7280-crd.dts
> > @@ -37,6 +37,15 @@
> > pinctrl-0 = <&edp_panel_power>;
> > };
> >
> > + edp_backlight: edp-backlight {
>
> Does this also move to qcard.dtsi? Why can't this be combined with the
> previous patch?
>
The nodes related to pwm are dependent on
https://patchwork.kernel.org/project/linux-arm-msm/list/?series=620127&state=*
We moved them to different patch so that the other patch can be merged without
depending on above series. I will rearrange to get backlight definitions also
here.
> > + compatible = "pwm-backlight";
> > +
> > + power-supply = <&vreg_edp_bp>;
> > + pwms = <&pm8350c_pwm 3 65535>;
> > +
> > + enable-gpios = <&pm8350c_gpios 7 GPIO_ACTIVE_HIGH>;
> > + };
> > +
> > vreg_edp_bp: vreg-edp-bp-regulator {
> > compatible = "regulator-fixed";
> > regulator-name = "vreg_edp_bp"; @@ -123,7 +132,9 @@
> > ap_ts_pen_1v8: &i2c13 {
> > edp_panel: edp-panel {
> > compatible = "edp-panel";
> >
> > + backlight = <&edp_backlight>;
> > power-supply = <&edp_3v3_regulator>;
> > +
>
> Nitpick: Remove this newline from this hunk and put it in when power-supply
> is introduced.
>
Okay, will make that change.
> > ports {
> > #address-cells = <1>;
> > #size-cells = <0>; @@ -172,6 +183,13
> > @@ ap_ts_pen_1v8: &i2c13 {
> > };
> > };
> >
> > +&pm8350c_pwm {
> > + status = "okay";
> > +
> > + pinctrl-names = "default";
> > + pinctrl-0 = <&edp_bl_pwm>;
>
> I see the pinctrl is used now but it would be easier to review this patch if
> the
> pinctrl was in this patch.
Okay. I will rearrange the hunks from this and the previous patch.
