Hi Jordan,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on robclark/msm-next]
[also build test ERROR on v4.16 next-20180406]
[if your patch is applied to the wrong git tree, please drop us a note to help 
improve the system]

url:    
https://github.com/0day-ci/linux/commits/Jordan-Crouse/drm-msm-GPU-crash-state/20180406-170513
base:   git://people.freedesktop.org/~robclark/linux msm-next
config: x86_64-rhel (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/gpu//drm/i915/i915_gpu_error.c: In function 'print_error_obj':
>> drivers/gpu//drm/i915/i915_gpu_error.c:549:4: error: implicit declaration of 
>> function 'error_puts'; did you mean 'err_puts'? 
>> [-Werror=implicit-function-declaration]
       error_puts(m, ascii85_encode(obj->pages[page][i], out));
       ^~~~~~~~~~
       err_puts
   cc1: some warnings being treated as errors

vim +549 drivers/gpu//drm/i915/i915_gpu_error.c

   520  
   521  static void print_error_obj(struct drm_i915_error_state_buf *m,
   522                              struct intel_engine_cs *engine,
   523                              const char *name,
   524                              struct drm_i915_error_object *obj)
   525  {
   526          char out[ASCII85_BUFSZ];
   527          int page;
   528  
   529          if (!obj)
   530                  return;
   531  
   532          if (name) {
   533                  err_printf(m, "%s --- %s = 0x%08x %08x\n",
   534                             engine ? engine->name : "global", name,
   535                             upper_32_bits(obj->gtt_offset),
   536                             lower_32_bits(obj->gtt_offset));
   537          }
   538  
   539          err_compression_marker(m);
   540          for (page = 0; page < obj->page_count; page++) {
   541                  int i, len;
   542  
   543                  len = PAGE_SIZE;
   544                  if (page == obj->page_count - 1)
   545                          len -= obj->unused;
   546                  len = ascii85_encode_len(len);
   547  
   548                  for (i = 0; i < len; i++)
 > 549                          error_puts(m, 
 > ascii85_encode(obj->pages[page][i], out));
   550          }
   551          err_puts(m, "\n");
   552  }
   553  

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno

Reply via email to