Hi!
11-Июн-2005 18:16 [EMAIL PROTECTED] (Shane M. Coughlan) wrote to
<freedos-user@lists.sourceforge.net>:
>>I download and make short tryings for OGEM3. If you interested, I
>>express my impressions (wishes and bug reports).
SMC> I would really value both your opinions and any bug reports you could make.
1. opengem3.zip: if pack ogem3.zip (inside distributive) with zero
compression, then its size become 9235k (instead 4550k), but resulting
distributive become 4395k (insted 4533k - gain -3%). But after packing
all tree into .RAR, result become 3279k (gain -28%).
2. opengem3.zip" distributive contains a lot of directories (9) and some
files, and all of them unpacked into root directory. All of them should
be installed _inside_ _one_, sensible directory (like GEM3) or, better,
into asked directory. Simplest way, how to do this (insde install.bat)
without external dialog utilities:
@echo off
if "%1"=="" goto ask-if-install
rem %1 is a user specified path
rem check if it exists and try to create it if not
if not exist %1 md %1
if not exist %1 echo Error creating target path...
if not exist %1 goto end
...continue...
goto end
:ASK-IF-INSTALL
echo ...
choice /c:1234
if errorlevel ...
...
if errorlevel 2 %0 d:\gem3
if errorlevel 1 %0 c:\gem3
...^C pressed...
Some batches, which depends on path of GEM, may be created on the fly by
install.bat.
3. install.bat: allowed to install only C: and D:.
4. install.bat: before asking about installed Windows, should be _also_
checked %win% variable. But in any case install.bat assumes, that Start
menu resides in the C:\Windows\Startm~1\Programs, and this is far from
reliable suggestion.
The more so, used XCOPY instead COPY. I thhink, MD+COPY is better: is MD
can't create C:\Windows\Startm~1\Programs\Opengem, then followed copying
should be ommited (because C:\Windows\Startm~1\Programs doesn't exist):
@echo off
if "%1"=="" goto ask-if-install
if "%2"=="" got processpath
md %2\opengem
if not exist %2\opengem\nul goto end
copy %1\links\*.* %2\opengem
goto end
:PROCESSPATH
rem %1 is a user specified path
...unpack
...ask if install to Windows...
...if answer not positive goto end
if "%win%"=="" %0 %1 c:\wndows
%0 %1 c:\wndows
:ASK-IF-INSTALL
5. all batch files currently contains absolute path (like setup.bat):
CD\GEMAPPS\GEMSYS\CHOICE
choice /c:12345
if errorlevel 5 goto 5
[...]
if errorlevel 1 goto 1
CLS
:1
ECHO OFF
REM Change the video driver
CD\GEMAPPS\GEMSYS\SETUP
VIDEO
GOTO CHOOSE
CLS
First, I don't understand why to use multiple "echo off", also as
unreachabled "goto" and "cls" after _jump_ to video.bat. Ie., you may
remove those lines. Second, you not process ^C after CHOICE (which return
zero errorlevel). Third, jumps should be relative (this allows to
install GEM into any subdirectory):
CD ..\CHOICE
choice /c:12345
[...]
if errorlevel 1 goto 1
...process ^C...
:1
REM Change the video driver
CD ..\SETUP
VIDEO
Or, better, there should be relative calls:
rem current directory is main GEM directory
apps\sys\choice\choice.exe /c:12345
[...]
if errorlevel 1 goto 1
...process ^C...
:1
apps\sys\setup\video.bat
And even shorter:
apps\sys\choice\choice.exe /c:12345
if errorlevel 5 goto exit
if errorlevel 4 goto help
if errorlevel 3 apps\sys\setup\printer.bat
if errorlevel 2 apps\sys\setup\sound.bat
if errorlevel 1 apps\sys\setup\video.bat
goto exit
6. whcarts\: there is .bak file; some timestamps (agenda.wch, chill.wch) are
broken.
7. gemapps\gemsys\chooice\doc\copying duplicates
gemapps\helpzone\license.txt, and choice.exe itself is hidden too deeply.
This is may impressions about setup and run process. If you wish, I continue
my remarks about working insid GEM. Also, if you wish, I may rework batch
files for you.
-------------------------------------------------------
This SF.Net email is sponsored by: NEC IT Guy Games. How far can you shotput
a projector? How fast can you ride your desk chair down the office luge track?
If you want to score the big prize, get to know the little guy.
Play to win an NEC 61" plasma display: http://www.necitguy.com/?r
_______________________________________________
Freedos-user mailing list
Freedos-user@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/freedos-user
