URL:
<http://gna.org/bugs/?25245>
Summary: SDL diplomacy dialog mostly prevents treaty
cancellation?
Project: Freeciv
Submitted by: jtn
Submitted on: Sun 30 Oct 2016 12:29:07 PM UTC
Category: client-sdl
Severity: 3 - Normal
Priority: 5 - Normal
Status: None
Assigned to: None
Originator Email:
Open/Closed: Open
Release: 2.5.5
Discussion Lock: Any
Operating System: Any
Planned Release:
Contains string changes: No
_______________________________________________________
Details:
Noticed looking at bug #25085:
The SDL clients treat the return value from pplayer_can_cancel_treaty() as a
boolean (in popup_diplomacy_dialog()), but it's actually an enum, and not one
such that a nonzero return implies ability to cancel.
I think (but haven't tested) that this will prevent treaty cancellation except
when it's illegal; the only time it'll behave as intended is if a senate
blocks treaty cancellation (in which case we present a button, to consult the
server). But this seems like a rather major bug to have gone undetected, so
maybe I've misread it.
(The comments for pplayer_can_cancel_treaty() itself also incorrectly imply
that it returns a bool.)
_______________________________________________________
Reply to this item at:
<http://gna.org/bugs/?25245>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
