Follow-up Comment #12, patch #7667 (project freeciv):

I like what I see. Some further issues.

> +      log_error("%s ", mapview_layer_name(t->layer_order[i]));
Accidentally included debugging code?

Some compilers needs tileset_layer_in_category() to return false after the
switch. Maybe you should add an assertion failure before the post switch
return statement?

Documentation: I think you should add a commented out layer_order option to
the bundled tilesets. Above it should be a comment explaining what it does,
what should be put in it etc. (See how it is done for the
unit_default_orientation option)


    _______________________________________________________

Reply to this item at:

  <http://gna.org/patch/?7667>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to