Follow-up Comment #2, patch #7678 (project freeciv):
I don't have libgreattao installed, so couldn't test to compile this yet. Some
comments based on reading the patch:
"+if test "x$req_fcmp_gtk2" = "xyes" ||
+ test "x$modinst" = "xall" ; then
+ AM_PATH_GTK_2_0([2.12.0],
..."
I assume you are adding this duplicate check for gtk2 modpack installer by
accident.
"- test "x$fcmp_qt" != "xyes" ;then
+ test "x$fcmp_qt" != "xyes"
+ test "x$fcmp_tao" != "xyes" ;then"
Syntax error breaking build (at least when fcmp_tao is not to be built).
Should have "&&" in the end of first line.
I didn't read mpgui_tao.c carefully yet, but some comments after quick look:
Do not introduce global variables (are they global intentionally?) before
includes, but list such things after includes.
When either postfix++ or ++prefix can be used, use postfix++. See
doc/CodingStyle if you haven't already.
Functions without comment header are not accepted.
Use fc_snprintf() instead of snprintf() to avoid some portability problems.
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?7678>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
