Follow-up Comment #1, patch #7664 (project freeciv):
Great to see some move on this old (I think) feature request :-) Tested it
quickly, mostly because I was interested by how you implemented it (I though
it would be more difficult). Noticed the following:
* It's not fully localized: Germans use "Strg" instead of "Ctrl", we
French-speaking people like "Maj" instead of "Shift". Some random language may
even not use "+" as a separator, or reverse the order of keys, or whatever.
Maybe use QKeySequence::toString for the keyboard part in shortcut_to_string
(btw make it a member of struct shortcut)
* Scroll wheel doesn't work, I would expect it to (but it's a bit different
technically, see QScrollWheelEvent)
* Non-ASCII keys don't work: my keyboard has «»êàéèç plus many fancy
keys with AltGr, and some layouts may have no ASCII key at all (eg Greek or
Russian). I think that storing the QKeySequence would solve it.
My 2¢ (<- yes I have the key for this on my keyboard)
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?7664>
_______________________________________________
Message posté via/par Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
