Follow-up Comment #2, patch #7393 (project freeciv): *invalid* is determined by: "one or more errors reported by the W3C validator" https://validator.w3.org/
So far there was one special case "(only) visually invalid" for the Dryads, that was discussed on the forum (link in patch #7476). For all not yet fixed SVGs in http://freeciv.wikia.com/wiki/Category:Broken_SVG there is a "check SVG" link on the flag page, if you click on it goes to the validator and reports the errors (red favicon=errors, green favicon=no errors, warnings ignored.) For all fixed SVGs I removed Template:Broken SVG (after checking that the SVG is really fixed, of course), the details of what I did to fix the SVG are documented on the corresponding flag page linked in the corresponding flag. For this patch #7393 we're talking about http://freeciv.wikia.com/wiki/File:Usa.svg as stated below, and in http://freeciv.wikia.com/wiki/File:Usa.svg?action=history you can see that I simply replaced an invalid SVG by the latest and greatest valid SVG from WikiMedia Commons. Most SVG flag patches follow this scheme. Another scheme (if commons doesn't have the flag, or its license might be unusable, worst case hre.svg in patch #7464) is to edit the SVG in a text editor, check that it's valid, upload result to Wikia, create patch, update flag page as "now valid" with a link to the patch (to be removed when the patch made it into SVN.) Radical scheme if commons fails, and "minor text editor issue" is not applicable (mostly obvious in the W3C validator error reports): Let rsvg-convert produce a valid SVG (invalid in, valid out), and continue as in the "text editor" procedure outlined above. Summary: All you're supposed to do is to copy the new SVG to SVN, and tag the patch as DONE. With as many bells and whistles as you like, e.g., add comment "needs new PNGs" for a patch, where I already stated that it needs new PNGs (3 or 4 cases), and if you also cannot use the convert_png perl-script, or if you tried the script, but the output sucks too much. Almost all SVG patches are only about the validity and need no new PNGs (example: Dryad). Sometimes I changed the license on the Wiki from (default) GPL to PD, if the commons source is PD. In all these cases there's a comment "PD is GPL compatible" in the patch for the attached SVG. _______________________________________________________ Reply to this item at: <http://gna.org/patch/?7393> _______________________________________________ Message sent via/by Gna! http://gna.org/ _______________________________________________ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev