Follow-up Comment #1, patch #7653 (project freeciv):

Yes, while(1) is horrible. I'd prefer while 1 or, because you obviously love
TRUE and FALSE, while TRUE.  

The new while (TRUE) is a matter of taste, admittedly not my taste, but okay. 


However, one case of while (FALSE) cries for an explanation in a *separate*
patch, or IOW, have you checked that it's a sound do ONCE case?

Likewise, it's no big deal, but please keep "prettifying" out of non-trivial
bug fixing. With all those convoluted music-non-stop SDL callbacks it
distracted me, when you also tackled a bunch of code style nits "while at it".


    _______________________________________________________

Reply to this item at:

  <http://gna.org/patch/?7653>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to