URL:
<http://gna.org/bugs/?24842>
Summary: Client should try harder to change server topology
when tileset forced with "-t"?
Project: Freeciv
Submitted by: jtn
Submitted on: Sun 10 Jul 2016 10:05:33 AM BST
Category: client
Severity: 3 - Normal
Priority: 5 - Normal
Status: None
Assigned to: None
Originator Email:
Open/Closed: Open
Release:
Discussion Lock: Any
Operating System: None
Planned Release: 2.6.0, 3.0.0
Contains string changes: None
_______________________________________________________
Details:
In my experience at the moment on S2_6/trunk, starting the client with a
forced tileset ("-t") does not cause the resulting game to have the topology
of the tileset.
There's longstanding code in client_start_server() which attempts to do this.
I haven't looked into why it isn't taking effect, but I could believe that
saved client-side server settings and ruleset preferences could both override
this very early setting.
I think that if a typical user has specified "-t tileset" on the command line,
they'd expect to get a game matching that topology. So I think we should
probably try harder to set it -- set the topology whenever the ruleset
changes, etc. Not sure how to resolve conflict between "-t" and previously
user-saved topology ID -- probably "-t" should override.
It is still useful for development purposes to allow the tileset and topology
to mismatch; this can be achieved by "/set topology" on the chatline after the
client has started its server, and probably by doing the same in the client
UI. A naive user blundering into this will at least get a warning when they
start the game so the ensuing weirdness should not be completely unexpected.
(It will not be possible to encounter this without using "-t" on
command-line.)
Similarly, when "-t" isn't specified, that code in client_start_server()
should *never* run in the post bug #16668 world.
_______________________________________________________
Reply to this item at:
<http://gna.org/bugs/?24842>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
