URL:
  <http://gna.org/patch/?6630>

                 Summary: Allow unmapped terrains to have identifier already
used by mapped terrain
                 Project: Freeciv
            Submitted by: cazfi
            Submitted on: Sat 21 Nov 2015 12:11:22 PM EET
                Category: general
                Priority: 5 - Normal
                  Status: In Progress
                 Privacy: Public
             Assigned to: None
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: 2.6.0, 3.0.0

    _______________________________________________________

Details:

When loading a savegame, patch #6607 makes it an error that a new terrain type
added to the ruleset since the creation of the savegame has a same identifier
as the identifier for some terrain in the savegame. That's because it uses
current identifier for those terrains that do not have mapping in the
savegame.
It should be legal for a ruleset author to both add a new terrain type and
then to swap (or otherwise rearrange) identifiers.

Solution would be savegame loading not to support unmapped terrains via their
current identifier, but to deduct that if a terrain has no mapping -> it was
not present at saving time -> it can't be used anywhere in the savegame.

That's easy for 2.6+ savegames, but older savegames with no mapping at all
need to be supported to some level. I think we can only make 2.5 -> 2.6
savecompat to add mapping table from the current ruleset version so that
"savegame identifier = current identifier" for all terrain types.

In general a ruleset cannot both support pre-2.6 savegames and change the
terrain mapping (except for simply adding new terrain types)




    _______________________________________________________

Reply to this item at:

  <http://gna.org/patch/?6630>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
Freeciv-dev mailing list
[email protected]
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to