Update of bug #21942 (project freeciv):
Status: None => Ready For Test
Planned Release: 2.5.0, 2.6.0 => 2.4.5, 2.5.0, 2.6.0,
3.0.0
_______________________________________________________
Follow-up Comment #10:
The fact that I cannot reproduce seems to indicate that our versions of gtk
behave differently.
>From you backtrace one can see that when cma presets are being filled to the
list, gtk signals cause cell_data_func() to be called already when the row is
being created. It would be only next operation to add data (cma preset name)
to it. cell_data_func() crashes when feeded row with NULL preset name on it.
Attached patch should protect cell_data_func() against such a crash. It also
fixes the minimal memory leak of fetched preset name not being freed. Patch
makes the change to both gtk2- and gtk3-client as it makes things only safer -
can't hurt gtk2-client either.
I hope you gtk signals cell_data_func() also at the right time - when actual
preset name then is there. It not doing that would mean that the currently
preset currently selected for the city would not be drawn italix & bold when
city dialog is (re)opened.
(file #23722)
_______________________________________________________
Additional Item Attachment:
File name: CmaNotNamedYet.patch Size:1 KB
_______________________________________________________
Reply to this item at:
<http://gna.org/bugs/?21942>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
[email protected]
https://mail.gna.org/listinfo/freeciv-dev
