URL:
  <http://gna.org/patch/?4988>

                 Summary: Always allow selected reqs to be met with nulls
                 Project: Freeciv
            Submitted by: persia
            Submitted on: Sat 26 Jul 2014 08:12:39 AM JST
                Category: general
                Priority: 5 - Normal
                  Status: Ready For Test
                 Privacy: Public
             Assigned to: persia
        Originator Email: 
             Open/Closed: Open
         Discussion Lock: Any
         Planned Release: 2.6.0

    _______________________________________________________

Details:

Unit Type flag requirements can be met when no unit type is passed to
is_req_active(), but other similar requirements cannot be, despite comments to
the effect that they should be in the code.  For the same reasons, VUT_OTYPE
requirements should be potentially met with a null request.

>From inspection, all callers that actually depend on unit attributes or output
type use these safely.



    _______________________________________________________

File Attachments:


-------------------------------------------------------
Date: Sat 26 Jul 2014 08:12:39 AM JST  Name:
always-allow-selected-reqs-to-be-met-with-nulls.patch  Size: 3kB   By: persia

<http://gna.org/patch/download.php?file_id=21556>

    _______________________________________________________

Reply to this item at:

  <http://gna.org/patch/?4988>

_______________________________________________
  Message sent via/by Gna!
  http://gna.org/


_______________________________________________
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev

Reply via email to