Follow-up Comment #1, patch #3550 (project freeciv):
Well, TBH, there's one major catch here: while things work as-is both in gtk2
and gtk3 clients, technically they only do that due to luck.
Even back in gtk2 its devs stressed that *all* of the drawing should be done
in 'expose-event' handler. It's still the same for gtk3 and 'draw'. The way
update_rect_at_mouse_pos() works (well, more exactly
update_selection_rectangle(x, y)), regardless of whether it's merged or not,
already pushes it.
But I don't see any way of implementing this without a major rewrite of not
only the client, but probably common code too.
I've merged it, cause while due to human reaction time, doing it like
city_activated_callback (cityrep.c) and impr_callback (citydlg.c) do (which I
didn't touched and already explained why it's IMHO unfixably broken) would
*seem* to work, it's the most natural place with access to the required data,
but at the same time, that data can't be as reliably retrieved anywhere else.
_______________________________________________________
Reply to this item at:
<http://gna.org/patch/?3550>
_______________________________________________
Message sent via/by Gna!
http://gna.org/
_______________________________________________
Freeciv-dev mailing list
[email protected]
https://mail.gna.org/listinfo/freeciv-dev
