https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=237714
Guido Falsi <madpi...@freebsd.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #204172|maintainer-approval? | Flags| | Attachment #204172|0 |1 is obsolete| | --- Comment #5 from Guido Falsi <madpi...@freebsd.org> --- Created attachment 204312 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=204312&action=edit revised patch I have uploaded a revised patch. This patch does not add an option, but leverages the WITH_DEBUG framework I kept your other changes, but reworked the patch to xfpm-settingsc basing it on newer upstream code. I also slightly changed the xfpm-backlight_helper.c patch to use a define for your magic number, use a smaller allocation and have less gratuitous changes to the code (white space for example). I'm gong to commit this patch in the next days unless you have strong objections. Please understand I don't feel comfortable adding a DEBUG knob to port options, so I'll not do that. The rest of the patch is almost the same as what you proposed with only minor changes. -- You are receiving this mail because: You are the assignee for the bug. _______________________________________________ freebsd-xfce@freebsd.org mailing list https://lists.freebsd.org/mailman/listinfo/freebsd-xfce To unsubscribe, send any mail to "freebsd-xfce-unsubscr...@freebsd.org"