https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=236438
Guido Falsi <madpi...@freebsd.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|New |Open
CC| |madpi...@freebsd.org
--- Comment #2 from Guido Falsi <madpi...@freebsd.org> ---
Hi,
Thanks for the patch, I had a look. While I do agree with adding DEBUG support,
I think it should be done the "proper" way.
In the ports tree there is support for the "WITH_DEBUG" flag, which
automatically disables optimizations, adds the -g flag and disables stripping
of binaries(or at least tries to).
If a port needs further flags they should be linked to this flag.
I have also discovered that DEBUG options are not a good idea [1]
So I'd rework this patch to not add a DEBUG option to the port but use the
WITH_DEBUG (which is also triggere by WITH_DEBUG_PORTS) flag to check if extrra
options should be enabled.
I'd try to avoid a DEBUG option. Adding WITH_DEBUG_PORTS to make.conf is quite
easy.
[1] https://reviews.freebsd.org/D15773
--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
freebsd-xfce@freebsd.org mailing list
https://lists.freebsd.org/mailman/listinfo/freebsd-xfce
To unsubscribe, send any mail to "freebsd-xfce-unsubscr...@freebsd.org"
