Oh Google, why "Reply to all" isn't the default? Forwarding to the mailing list
---------- Forwarded message ---------- From: Rostislav Krasny <rosti....@gmail.com> Date: Tue, Nov 5, 2013 at 10:48 AM Subject: Re: vendorinfo file To: Olivier Duchateau <duchateau.oliv...@gmail.com> On Tue, Nov 5, 2013 at 8:10 AM, Olivier Duchateau <duchateau.oliv...@gmail.com> wrote: > 2013/11/5 Rostislav Krasny <rosti....@gmail.com>: >> On Tue, Nov 5, 2013 at 12:45 AM, Rostislav Krasny <rosti....@gmail.com> >> wrote: >>> On Tue, Nov 5, 2013 at 12:22 AM, Olivier Duchateau >>>> See commit log, here >>>> http://git.xfce.org/xfce/libxfce4ui/commit/xfce4-about/main.c?id=4a14ef81cdc6f3e45b63eb42ca41c6af50c9c0c4 >>> >>> See the full version of this file. If the VENDOR_INFO macro isn't >>> defined, all that vendor specified code is disabled. >>> >>> http://git.xfce.org/xfce/libxfce4ui/tree/xfce4-about/main.c >>> >>> And according to libxfce4ui/tree/configure.ac.in the VENDOR_INFO seems >>> to be defined only when '--with-vendor-info' is used with some not >>> empty value. >> >> Finally I tested it by changes attached in the libxfce4menu.diff file. >> After this change the xfce4-about program shows no vendor information >> (neither vendor name in the version text nor vendor tab) and doesn't >> print any warning in the console it is ran from. >> >> I don't insist in this change. If you want to keep >> '--with-vendor-info=FreeBSD' and to add some vendorinfo file with >> FreeBSD about and advertising information, it would be nice too. Just >> make a choice. > > I disagree with you, new tab will be created if length of file is > greater than zero. If file doesn't exists or is empty nothing append > (see xfce_about_vendor() function). > > --with-vendor-info=FreeBSD is used in main() function (from line 482) > as xfce_about_vendor() doesn't initialize new tab, OS is only display. Yes you're right. I probably tested it with a file containing only a newline. Anyway the '--with-vendor-info=FreeBSD' seems to be unnecessary. You explained it as a workaround and my patch shows that no such workaround is needed. If you don't want the vendor tab with some appropriate text to appear in the xfce4-about, it's better to disable it completely than making an empty file that nobody really needs. _______________________________________________ freebsd-xfce@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-xfce To unsubscribe, send any mail to "freebsd-xfce-unsubscr...@freebsd.org"
