On 24 November 2010 11:19, Hans Petter Selasky <[email protected]> wrote: > Hi, > > Please find attached official usbdump patch from HPS trying to re-use as much > as possible of Weongyo's code which was committed not long ago. You need to > SVN up to the latest 9-current. > @@ -270,7 +122,7 @@ > * The kernel needs to be able to verify an application's filter code. > * Otherwise, a bogus program could easily crash the system. > */ > -static int > +static uint8_t > usbpf_validate(const struct usbpf_insn *f, int len) > {
Not related to the patch as a whole, but changing the return code of a yes/no function from int to uint8_t doesn't save anything and I think is less readable. Andrew _______________________________________________ [email protected] mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-usb To unsubscribe, send any mail to "[email protected]"
