On Sat, Dec 29, 2012 at 08:17:18PM +0100, Christoph Mallon wrote: > On 29.12.2012 17:02, Diane Bruce wrote: > >> /* Create new group and copy old group into it. */ > >> - if ((newgr = malloc(len)) == NULL) > >> + if ((dst = malloc(len)) == NULL) > >> return (NULL); > >> + newgr = (struct group*)dst; > > > > Unfortunately the new compiler (clang) will error out on this. It's > > really anal. The error will be that it cannot convert char * alignment > > to struct group * alignment. 1 vs. 4 (or 8). BTDT > > This sounds like a bug. > First, it should not be an error, but at most a warning.
Please take this up with toolch...@freebsd.org > Second, the cast is fine, as the pointer itself is a result of malloc(). > Obviously clang only checks the type of the variable. > Probably, the diagnostic can be suppressed with an intermediate cast to void*. > Third, the other casts (newgr + 1 casted to a char** and so on) are > borderline invalid due to strict aliasing rules. > Therefore I prefer my method of chopping off bytes of a char buffer instead > of munging differently typed pointers. > > Christoph - Diane -- - d...@freebsd.org d...@db.net http://www.db.net/~db _______________________________________________ freebsd-toolchain@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"
