These look generally good. Just one thing I had a question on: # +# Enable FreeBSD kernel-specific printf format specifiers. Also instruct gcc to +# enable some diagnostics, which make it easier to pinpoint tinderbox failures. +CFLAGS+= -fformat-extensions -fdiagnostics-show-option +
Does this put sand in the gears of clang support? Warner On May 27, 2011, at 5:51 AM, Alexander Best wrote: > hi there, > > i would like to hear people's opinion regarding the following patch. it > features the following semantic changes: > > 1) -W is now called -Wextra > 2) move -fformat-extensions and -fdiagnostics-show-option out of CWARNFLAGS, > since they aren't really warnings. this will now let anybody use custom > CWARNFLAGS without having to remember to add -fformat-extensions in order > not to break buildworld. > 3) rearrange "\" characters, as to avoid double spaces > 4) when building kernel modules, -fstack-protector was added to CFLAGS twice. > this should now be solved. > > cheers. > alex > > -- > a13x > <kern.mk-bsy.sys.mk.patch>_______________________________________________ > freebsd-toolchain@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain > To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org" _______________________________________________ freebsd-toolchain@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/freebsd-toolchain To unsubscribe, send any mail to "freebsd-toolchain-unsubscr...@freebsd.org"
